benlangmuir added a comment. In D132405#3747232 <https://reviews.llvm.org/D132405#3747232>, @jansvoboda11 wrote:
> I'd like to see this split into multiple patches. I can see some formatting > changes, removal of `CompilerInvocation` from `ModuleDeps`, isolated changes > to `Tooling`, etc. That'd make it much easier to review. `ToolInvocation` change: https://reviews.llvm.org/D132615 Remove `CompilerInvocation` from `ModuleDeps`: https://reviews.llvm.org/D132616 Factoring out the `addModule*Files` functions, sink `DirectPrebuiltModularDeps`, etc: https://reviews.llvm.org/D132617 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132405/new/ https://reviews.llvm.org/D132405 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
