jhuber6 added a comment.

In D132607#3747394 <https://reviews.llvm.org/D132607#3747394>, @tra wrote:

>> Should these be merged into a public interface via Object/OffloadBinary.h?
>
> I'm all for consolidating relevant code.

Basically it would be a free function doing that `extractFromBuffer` does here. 
I would also need to define a wrapper around `OwningBinary<OffloadBinary>` as 
that's what I use in the linker wrapper.

I'm not sure if it would be easier to consolidate this before or after this 
patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132607/new/

https://reviews.llvm.org/D132607

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to