Author: Nico Weber Date: 2022-08-23T10:12:52-04:00 New Revision: cd24120c9d9544b202641fbff46be38175bb2470
URL: https://github.com/llvm/llvm-project/commit/cd24120c9d9544b202641fbff46be38175bb2470 DIFF: https://github.com/llvm/llvm-project/commit/cd24120c9d9544b202641fbff46be38175bb2470.diff LOG: [clang] Remove a FIXME that we can't fix I added this recently, but it looks like several tests very intentionally check that `-mios-version-min=foo --target=x86_64-apple-ios` does simulator builds. So we can't easily remove this hack, even though it makes little sense in an arm mac world. (Here, you _have_ to say `-mios-simulator-version-min=` or `--target=arm64-apple-ios-simulator`.) The tests that check this: Clang :: Driver/darwin-ld.c Clang :: Driver/darwin-simulator-macro.c Clang :: Driver/darwin-version.c No behavior change. Differential Revision: https://reviews.llvm.org/D132400 Added: Modified: clang/lib/Driver/ToolChains/Darwin.cpp Removed: ################################################################################ diff --git a/clang/lib/Driver/ToolChains/Darwin.cpp b/clang/lib/Driver/ToolChains/Darwin.cpp index 2a581a17bd09..c2a344d241a9 100644 --- a/clang/lib/Driver/ToolChains/Darwin.cpp +++ b/clang/lib/Driver/ToolChains/Darwin.cpp @@ -2241,7 +2241,6 @@ void Darwin::AddDeploymentTarget(DerivedArgList &Args) const { DarwinEnvironmentKind Environment = OSTarget->getEnvironment(); // Recognize iOS targets with an x86 architecture as the iOS simulator. - // FIXME: Remove this. if (Environment == NativeEnvironment && Platform != MacOS && Platform != DriverKit && OSTarget->canInferSimulatorFromArch() && getTriple().isX86()) _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
