tra added inline comments.

================
Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-gfx11.cl:23
+
+// Test mismatched argument and return types are handled.
+
----------------
Is there a particular reason for this test?

Argument and return value type checks should've been handled by `Sema` based on 
builtin definition.

Integer and float conversions should've been done automatically, too.

We already have tests for all of that.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132140/new/

https://reviews.llvm.org/D132140

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to