wyt added inline comments.
================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:144
llvm::Optional<DataflowAnalysisState<typename AnalysisT::Lattice>>>>
-runDataflowAnalysis(
+runDataflowAnalysisOnCFG(
const ControlFlowContext &CFCtx, AnalysisT &Analysis,
----------------
gribozavr2 wrote:
>
Cannot be renamed currently, as the use between the function that applies to
`CFGElement` and `CFGStmt` is ambiguous. Added a FIXME to rename after we have
updated the implementation for users and remove the function that acts on
`CFGStmt`s.
================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:83
template <typename AnalysisT>
-llvm::Error checkDataflow(
+llvm::Error checkDataflowOnCFG(
llvm::StringRef Code,
----------------
gribozavr2 wrote:
>
Same as above, using the same name for the function that applies to
`CFGElement` and `CFGStmt` is ambiguous.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131614/new/
https://reviews.llvm.org/D131614
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
