rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Yeah, I think this makes sense on balance, even though it does create a weird
situation for the `ASTPrinter` case, where we don't really want to transfer
ownership of the stream.
================
Comment at: lib/CodeGen/CodeGenAction.cpp:705
@@ -703,3 +704,3 @@
case Backend_EmitNothing:
- return nullptr;
+ return {};
case Backend_EmitMCNull:
----------------
I think `return nullptr;` would be clearer here.
================
Comment at: lib/Frontend/CompilerInstance.cpp:599
@@ -606,3 +598,3 @@
<<
EC.message();
- return nullptr;
+ return {};
}
----------------
Likewise.
https://reviews.llvm.org/D21537
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
