ChuanqiXu accepted this revision. ChuanqiXu added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/include/clang/Sema/Sema.h:2264 + /// be checked at the end of the TU. + llvm::SmallPtrSet<const Decl *, 8> PendingInlineFuncDecls; + ---------------- I'm curious why the element is not `FunctionDecl`? ================ Comment at: clang/lib/Sema/Sema.cpp:1262 + if (auto *FDD = FD->getDefinition()) { + DefInPMF = FDD->getOwningModule()->isPrivateModule(); + if (!DefInPMF) ---------------- nit: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128328/new/ https://reviews.llvm.org/D128328 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits