beanz added inline comments.
================ Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:98 + if (HLSLNumThreadsAttr *NumThreadsAttr = FD->getAttr<HLSLNumThreadsAttr>()) { + const StringRef NumThreadsKindStr = "dx.numthreads"; + std::string NumThreadsStr; ---------------- This isn't DirectX-specific, so we should name it `hlsl`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits