dblaikie added a comment.

I guess the other way to test for pod-for-purposes-of-ABI is IRgen. Looks like 
MSVC isn't observable based on sizeof or alignof on these issues (the previous 
godbolt shows MSVC's answer to alignment for the packed and size for the 
trailing packing don't change based on any of the variations (pod, non-pod, 
pod-with-defaulted-special-members)) - but should be observable based on the 
returning ABI.

Ah, here we go: https://godbolt.org/z/sd88zTjPP

So MSVC does consider the defaulted special member as still a valid 
pod-for-purposes-of-ABI and clang is incorrect/not ABI compatible with this. So 
MSVC does want this fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119051/new/

https://reviews.llvm.org/D119051

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to