jhuber6 added a comment.

In D129694#3717166 <https://reviews.llvm.org/D129694#3717166>, @ssquare08 wrote:

> The OpenMP kernel names you mentioned are also generated separately by the 
> host and the device. Would you be okay generating declare target mangle names 
> separately by host and device using the same utility function 
> `getTargetEntryUniqueInfo`?
>
> If you still think it should only be generated only once by the host, what is 
> a good way of doing this since we can't modify the name in VarDecl?

I thought we already emitted the mangled name at least on the device side. I 
was suggesting that we just use the same name on the host so we don't need to 
worry about a host-side and device-side name difference and we can get rid of 
the extra argument to all the offload entry functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129694/new/

https://reviews.llvm.org/D129694

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to