aaron.ballman added a comment. In D131423#3714318 <https://reviews.llvm.org/D131423#3714318>, @shafik wrote:
> In D131423#3712083 <https://reviews.llvm.org/D131423#3712083>, @inclyc wrote: > >> @aaron.ballman @shafik (Help wanted). These type traits will not cause >> clang to crash if current patch applied, but the `bool x` in the test case >> will evaluate to `false`. I think the problem behind the github issue is >> that we didn't check the number of arguments for builtin type traits like >> `__is_constructible` >> >> I want to ask what is our expected behavior for this, give an error like >> using `std::is_constructible` or just consider `__is_constructible` should >> always have a bool value? Should we report a warning but compile translation >> unit, or report an error and terminate? > > I think it should be an error but @aaron.ballman may have a different idea. I agree; I think it should be an error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131423/new/ https://reviews.llvm.org/D131423 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
