manmanren added a comment. In http://reviews.llvm.org/D22270#483027, @spyffe wrote:
> Thank you very much for your review, Manman! I can implement all your > individual fixes, those look fine. In answer to two of your bigger > questions, though: > > - I see what you mean about the definition of an anonymous structure. It > looks like our structure is an //untagged// structure, not an //anonymous// > one. That said, this change is safe for all the places that use this > function, so it may be appropriate to change the name to > `findAnonymousStructOrUnionIndex`. What do you think? Sounds good! > - The test case is unfortunately only an approximation to the more > complicated behavior that occurs in lldb. The difference is that the testing > infrastructure inside Clang does not implement an ExternalASTSource, which > LLDB does. As a result, I've used the test case to verify that we don't > break parsing by making this change. Ok, thanks for the explanation! Cheers, Manman Repository: rL LLVM http://reviews.llvm.org/D22270 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
