aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:70
@@ +69,3 @@
+ if (IndexExpr->isValueDependent())
+ return; // we check in the specialization
+
----------------
Comments should be complete sentences (capitalization and punctuation).
================
Comment at:
test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index-c++03.cpp:7
@@ +6,3 @@
+ int get() {
+ // The next line used to crash the check (in C++03 mode only)
+ return x[index];
----------------
Missing a full stop.
http://reviews.llvm.org/D22190
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
