richard.barton.arm added a subscriber: richard.barton.arm.
richard.barton.arm added a comment.

Hi all

At first glance I thought this would be something that is in the ACLE, so was 
going to give an opinion. On second look, this is not actually an ACLE macro, 
and seems to be a clang special - my arm-none-eabi-gcc 5.4.2 does not emit it. 
I think it would be best to use the right names in all circumstances, although 
I appreciate the situation has not been made easy by ARM giving two names to 
the same thing. If that approach is not practical, then Tim's patch is probably 
ok.

The thinking behind not having this in the ACLE by the way is that ACLE now 
tries to define feature test macros per architectural feature rather than 
generationally. The one exception is the `__ARM_ARCH` macro and it would not be 
practical to describe all the changes between e.g. ARMv7 and ARMv8 via 
individual macros. Given that, the meaning of this macro can be expressed by 
combining the `__ARM_ARCH`, `__ARM_FP` and `__ARM_FEATURE_FMA` macros to pick 
between VFPv2,VFPv3,...,FP-ARMv8.


http://reviews.llvm.org/D22272



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to