ckissane added inline comments.

================
Comment at: llvm/include/llvm/Support/Compression.h:48-51
+  Error decompress(ArrayRef<uint8_t> Input, uint8_t *UncompressedBuffer,
+                   size_t &UncompressedSize) {
+    return Decompress(Input, UncompressedBuffer, UncompressedSize);
+  }
----------------
dblaikie wrote:
> Could we skip this wrapper & just have the underlying function (& also we 
> shouldn't be overloading by case like this anyway - please name all the 
> decompress/compress functions with the same case/spelling)
good point


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130516/new/

https://reviews.llvm.org/D130516

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to