ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:134 StorageLocation *ThisPointeeLoc = nullptr; + StorageLocation *ReturnLoc = nullptr; }; ---------------- This looks optional (since it is a pointer). If so, please comment to explain. ================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:224-225 + /// Returns the storage location of the return value or null if it was not set + /// yet. + StorageLocation *getReturnStorageLocation() const; ---------------- This implies a timing/initialization aspect to its state. Is this necessary? If not, can we restructure to avoid it? Alternatively, if it is valid to have it unset, please update the comment to reflect. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130600/new/ https://reviews.llvm.org/D130600 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
