phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/include/clang/Basic/ProfileList.h:31-38
+ enum ExclusionType {
+ /// Profiling is allowed.
+ ALLOW,
+ /// Profiling is skipped using the \p skipprofile attribute.
+ SKIP,
+ /// Profiling is forbidden using the \p noprofile attribute.
+ FORBID,
----------------
It's more common in LLVM to use capitalized names for enum values, see
https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130808/new/
https://reviews.llvm.org/D130808
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
