junaire added inline comments.
================ Comment at: clang/include/clang/Sema/Sema.h:4022 + ExprResult &SrcExpr, bool DoFunctionPointerConversion = false, + bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(), + QualType DestTypeForComplaining = QualType(), ---------------- GabrielRavier wrote: > junaire wrote: > > Normally we don't clang-format legacy code like this, as it's bad for git > > blame. > I've undone the clang-formatting on this Oh, I'm sorry about it I think I missed something here. So basically if you touched the code then format it is a good choice. I thought there was nothing changed here but only formatting, that's something we usually want to avoid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/ https://reviews.llvm.org/D130827 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
