xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.

I'd love to see some comments in the source code to make sure one will not sue 
these facilities for other purposes that this was not designed to do. 
Alternatively, `ContextSensitive` option could be renamed to 
`NonRecursiveContextSensitive`.



================
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:512-513
       // have the callee body available in the translation unit.
       if (!Options.ContextSensitive || F->getBody() == nullptr)
         return;
 
----------------
Since we do not support recursion (and only do inlining with the depth of one), 
I think we should have a check here to avoid a inlining recursive call. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130726/new/

https://reviews.llvm.org/D130726

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to