erichkeane added inline comments.
================ Comment at: clang/test/SemaCXX/enum-scoped.cpp:330 namespace PR35586 { - enum C { R, G, B }; + enum C { R=-1, G, B }; enum B { F = (enum C) -1, T}; // this should compile cleanly, it used to assert. ---------------- shafik wrote: > @erichkeane not sure if this fix for the test maintains the original intent > of the test or not. From the looks of it, the problem (https://github.com/llvm/llvm-project/commit/bf5fad86db497775a4f0279b8a806d150c0fa201) was that the RHS of this expression (`F = (enum C) -1`) was not an ICE, it was an eum. So I don't think this changes the AST at all, which should have hit the same crash. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130058/new/ https://reviews.llvm.org/D130058 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits