thakis added inline comments.
================ Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/misc/ConfusableTable/BUILD.gn:1 -executable("make-confusable-table") { +executable("clang-tidy-confusable-chars-gen") { deps = [ "//llvm/lib/Support" ] ---------------- Thanks for attempting to update the GN build, but if you don't test it it's less confusing to not touch it at all. I fixed it in dd428a571c69621d5b6eb2e0e3ce5497c304fb2c and I was confused for a bit since this file here was already updated. (I suppose the GN build wouldn't have broken if you hadn't changed this file and I wouldn't have noticed and not renamed the executable there for a while…) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129798/new/ https://reviews.llvm.org/D129798 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits