aaron.ballman added inline comments.

================
Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:370
+def note_constexpr_unscoped_enum_out_of_range : Note<
+  "store of value outside of the range of unscoped enum, valid values %0 to 
%1">;
 def err_experimental_clang_interp_failed : Error<
----------------
How about: `integer value %0 is outside the valid range of values [%1, %2) for 
this enumeration type`

This also would nicely handle the case where the value comes as a result of a 
complex constant expression or constexpr function call, etc and isn't 
immediately obvious to the reader.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130058/new/

https://reviews.llvm.org/D130058

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to