Ericson2314 added inline comments.

================
Comment at: clang/CMakeLists.txt:81
     # path is removed.
-    set(MAIN_INCLUDE_DIR "${LLVM_INCLUDE_DIR}")
+    set(INCLUDE_DIRS ${LLVM_INCLUDE_DIRS})
     set(LLVM_OBJ_DIR "${LLVM_BINARY_DIR}")
----------------
sebastian-ne wrote:
> Do we need to add `"${LLVM_BINARY_DIR}/include"` here as well?
Pretty sure we shouldn't be cause that should be one of the elements of the 
list when LLVM is also being built in this CMake invocation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130553/new/

https://reviews.llvm.org/D130553

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to