kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks, lgtm! ================ Comment at: clang-tools-extra/clangd/XRefs.cpp:89 + return MD; + auto *DeclCtx = cast<Decl>(MD->getDeclContext()); + if (DeclCtx->isInvalidDecl()) ---------------- can you have a comment here saying "Look for method definition inside the implementation decl" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130095/new/ https://reviews.llvm.org/D130095 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
