tejohnson added inline comments.
================ Comment at: llvm/lib/LTO/ThinLTOCodeGenerator.cpp:456 + updatePublicTypeTestCalls(TheModule, + /* WholeProgramVisibilityEnabledInLTO */ false); ---------------- Add a comment to see note at call to updateVCallVisibilityInIndex for why parmeter is set to false. ================ Comment at: llvm/test/LTO/X86/public-type-test.ll:3 + +; RUN: opt -module-summary %s -o %t.bc +; RUN: llvm-lto --thinlto-action=run -exported-symbol=_main %t.bc --thinlto-save-temps=%t2 ---------------- The new version switched this from a regular LTO to ThinLTO test. I think we need both. Can you move the new version into llvm/test/ThinLTO/X86 and make this version back to testing the regular LTO old API handling, but with checks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128955/new/ https://reviews.llvm.org/D128955 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
