martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/lib/AST/ASTImporter.cpp:3237
+ ParentMapContext &ParentC = DC->getParentASTContext().getParentMapContext();
+ DynTypedNodeList P = ParentC.getParents(*S);
+ while (!P.empty()) {
----------------
martong wrote:
> martong wrote:
> >
> The first call of `getParents` will create the parent map, via a full-blown
> AST visitation. I am concerned a bit about the additional performance
> overhead. Could you please run some measurements? (E.g. a CTU run on
> `protobuf` and `bitcoin` with our internal CI infra)
> The first call of `getParents` will create the parent map, via a full-blown
> AST visitation. I am concerned a bit about the additional performance
> overhead. Could you please run some measurements? (E.g. a CTU run on
> `protobuf` and `bitcoin` with our internal CI infra)
I've seen the measurement results, they look good.
{F23872820}
We have errors in the CTU analysis of 'qtbase' and 'contour' even with the base
line. The duration for the remaining 3 (xerces, protobuf, bincoin) looks good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129640/new/
https://reviews.llvm.org/D129640
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
