arsenm added a comment.

In D128907#3650750 <https://reviews.llvm.org/D128907#3650750>, @jdoerfert wrote:

> That said, I doubt this is even what we want. Throwing away the benefits of 
> the noundef for one special case. IIRC, I mentioned alternatives in the other 
> discussion already,... not that I have a link handy.

I've spent a while thinking about this and don't see a better option. It's one 
special case, but since that special case can be called from arbitrary user 
code, I don't see how we can preserve noundef. We can't specially treat the 
handful of special intrinsics/operands for this, since we would transitively 
need to apply this to any user code which calls those functions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128907/new/

https://reviews.llvm.org/D128907

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D128907:... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH] D12... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... Sameer Sahasrabuddhe via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D12... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D12... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D12... Matt Arsenault via Phabricator via cfe-commits

Reply via email to