aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

The changes here LGTM aside from one thing (which I'll take care of when I land 
the changes on your behalf). ParseDeclCXX.cpp still has a bunch of unrelated 
whitespace changes in it which should be backed out. We don't want unrelated 
changes sneaking in to a commit because that makes a future `git blame` that 
much harder on folks. But, rather than have you fiddle with it, I can strip 
them easily enough on my end, so this is just something to keep in mind for 
next time.

Thank you for the cleanup here!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129048/new/

https://reviews.llvm.org/D129048

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to