MaskRay added a comment.

Linux tests organization isn't great. --sysroot tests both include and library 
search paths, so ideally we use one RUN line to test both.

The name of linux-header-search.cpp focus on just include search path. For 
FreeBSD/OpenBSD, if you want to start in a clean state, consider adding the RUN 
line to a generic test (if --sysroot is considered a core functionality) or a 
test with name implying "cross compilation" (that's why I created 
linux-cross.cpp).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129654/new/

https://reviews.llvm.org/D129654

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to