HazardyKnusperkeks added a comment.

In D129443#3645795 <https://reviews.llvm.org/D129443#3645795>, @Vigilans wrote:

> In my knowledge of clang-format, `Requires Clause` and `Requires Expression` 
> are treated differently. 
> <snip>

+1 for the enum, even if we only have 2 options yet.

And yes, the option is wrongly named. You want to indent/align requires 
expressions, not clauses.

The tests seem mostly to suffice. You could add a test where the outer scope is 
indented, e.g. a class with a member function, and a test where the expression 
is used within an if.

Please also run `clang/docs/tools/dump_format_style.py` to update the 
`ClangFormatStyleOptions.rst`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129443/new/

https://reviews.llvm.org/D129443

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to