This revision was automatically updated to reflect the committed changes.
Closed by commit rG93cd159ca9d3: [clangd] Remove `allCommitCharacters`
(authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D129579?vs=444015&id=444051#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129579/new/
https://reviews.llvm.org/D129579
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-tools-extra/clangd/test/initialize-params.test
Index: clang-tools-extra/clangd/test/initialize-params.test
===================================================================
--- clang-tools-extra/clangd/test/initialize-params.test
+++ clang-tools-extra/clangd/test/initialize-params.test
@@ -13,35 +13,6 @@
# CHECK-NEXT: "automaticReload": true
# CHECK-NEXT: },
# CHECK-NEXT: "completionProvider": {
-# CHECK-NEXT: "allCommitCharacters": [
-# CHECK-NEXT: " ",
-# CHECK-NEXT: "\t",
-# CHECK-NEXT: "(",
-# CHECK-NEXT: ")",
-# CHECK-NEXT: "[",
-# CHECK-NEXT: "]",
-# CHECK-NEXT: "{",
-# CHECK-NEXT: "}",
-# CHECK-NEXT: "<",
-# CHECK-NEXT: ">",
-# CHECK-NEXT: ":",
-# CHECK-NEXT: ";",
-# CHECK-NEXT: ",",
-# CHECK-NEXT: "+",
-# CHECK-NEXT: "-",
-# CHECK-NEXT: "/",
-# CHECK-NEXT: "*",
-# CHECK-NEXT: "%",
-# CHECK-NEXT: "^",
-# CHECK-NEXT: "&",
-# CHECK-NEXT: "#",
-# CHECK-NEXT: "?",
-# CHECK-NEXT: ".",
-# CHECK-NEXT: "=",
-# CHECK-NEXT: "\"",
-# CHECK-NEXT: "'",
-# CHECK-NEXT: "|"
-# CHECK-NEXT: ],
# CHECK-NEXT: "resolveProvider": false,
# CHECK-NEXT: "triggerCharacters": [
# CHECK-NEXT: ".",
Index: clang-tools-extra/clangd/ClangdLSPServer.cpp
===================================================================
--- clang-tools-extra/clangd/ClangdLSPServer.cpp
+++ clang-tools-extra/clangd/ClangdLSPServer.cpp
@@ -534,10 +534,11 @@
}},
{"completionProvider",
llvm::json::Object{
- {"allCommitCharacters",
- {" ", "\t", "(", ")", "[", "]", "{", "}", "<",
- ">", ":", ";", ",", "+", "-", "/", "*", "%",
- "^", "&", "#", "?", ".", "=", "\"", "'", "|"}},
+ // We don't set `(` etc as allCommitCharacters as they interact
+ // poorly with snippet results.
+ // See https://github.com/clangd/vscode-clangd/issues/357
+ // Hopefully we can use them one day without this side-effect:
+ // https://github.com/microsoft/vscode/issues/42544
{"resolveProvider", false},
// We do extra checks, e.g. that > is part of ->.
{"triggerCharacters", {".", "<", ">", ":", "\"", "/", "*"}},
Index: clang-tools-extra/clangd/test/initialize-params.test
===================================================================
--- clang-tools-extra/clangd/test/initialize-params.test
+++ clang-tools-extra/clangd/test/initialize-params.test
@@ -13,35 +13,6 @@
# CHECK-NEXT: "automaticReload": true
# CHECK-NEXT: },
# CHECK-NEXT: "completionProvider": {
-# CHECK-NEXT: "allCommitCharacters": [
-# CHECK-NEXT: " ",
-# CHECK-NEXT: "\t",
-# CHECK-NEXT: "(",
-# CHECK-NEXT: ")",
-# CHECK-NEXT: "[",
-# CHECK-NEXT: "]",
-# CHECK-NEXT: "{",
-# CHECK-NEXT: "}",
-# CHECK-NEXT: "<",
-# CHECK-NEXT: ">",
-# CHECK-NEXT: ":",
-# CHECK-NEXT: ";",
-# CHECK-NEXT: ",",
-# CHECK-NEXT: "+",
-# CHECK-NEXT: "-",
-# CHECK-NEXT: "/",
-# CHECK-NEXT: "*",
-# CHECK-NEXT: "%",
-# CHECK-NEXT: "^",
-# CHECK-NEXT: "&",
-# CHECK-NEXT: "#",
-# CHECK-NEXT: "?",
-# CHECK-NEXT: ".",
-# CHECK-NEXT: "=",
-# CHECK-NEXT: "\"",
-# CHECK-NEXT: "'",
-# CHECK-NEXT: "|"
-# CHECK-NEXT: ],
# CHECK-NEXT: "resolveProvider": false,
# CHECK-NEXT: "triggerCharacters": [
# CHECK-NEXT: ".",
Index: clang-tools-extra/clangd/ClangdLSPServer.cpp
===================================================================
--- clang-tools-extra/clangd/ClangdLSPServer.cpp
+++ clang-tools-extra/clangd/ClangdLSPServer.cpp
@@ -534,10 +534,11 @@
}},
{"completionProvider",
llvm::json::Object{
- {"allCommitCharacters",
- {" ", "\t", "(", ")", "[", "]", "{", "}", "<",
- ">", ":", ";", ",", "+", "-", "/", "*", "%",
- "^", "&", "#", "?", ".", "=", "\"", "'", "|"}},
+ // We don't set `(` etc as allCommitCharacters as they interact
+ // poorly with snippet results.
+ // See https://github.com/clangd/vscode-clangd/issues/357
+ // Hopefully we can use them one day without this side-effect:
+ // https://github.com/microsoft/vscode/issues/42544
{"resolveProvider", false},
// We do extra checks, e.g. that > is part of ->.
{"triggerCharacters", {".", "<", ">", ":", "\"", "/", "*"}},
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
