Ilod added a comment.

LGTM

Plugins tests are still disabled by lit.cfg I think, as it only checks for 
enable_shared, which is disabled. I suppose we could wait for both this and the 
SampleAnalyzerPlugin to be patched before enabling plugins tests if we have 
LLVM_EXPORT_SYMBOLS_FOR_PLUGINS, as every plugin test should work after this.


Repository:
  rL LLVM

http://reviews.llvm.org/D21385



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to