dhruvachak added a comment. In D102107#3640232 <https://reviews.llvm.org/D102107#3640232>, @jdoerfert wrote:
> In D102107#3640198 <https://reviews.llvm.org/D102107#3640198>, @dhruvachak > wrote: > >> Thanks. I followed the above steps and regenerated a couple of the AST tests >> but they still fail. Perhaps I am missing some options? >> >> I currently have a handful of clang test failures where regen did not work. >> I am going to update the patch, post the current test results, and we can >> figure out how to regen the rest before we land this patch. > > So, generate check lines for new tests in a separate patch first. Not sure what you mean by new tests. make check-clang has a few failures on existing tests. I think all of them are regen issues. I will post the results. > For the AST ones, you need to take the run line of the test, not what I > posted there. If it doesn't work, one needs to check why. Hard to diagnose > and I don't remember if there is something else. Maybe you need to only > include part of it? Yes, I took the run line of the test. The regen worked OK, I removed the old CHECK lines and added the new ones. But make check-clang still flags it as a failure. As you said, we need to understand why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
