shafik added inline comments.
================ Comment at: clang/lib/Serialization/ASTReader.cpp:5174 std::string &SuggestedPredefines) override { - return checkPreprocessorOptions(ExistingPPOpts, PPOpts, nullptr, FileMgr, + return checkPreprocessorOptions(PPOpts, ExistingPPOpts, nullptr, FileMgr, SuggestedPredefines, ExistingLangOpts); ---------------- Nitpick `/*Diags=*/nullptr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129277/new/ https://reviews.llvm.org/D129277 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits