ChuanqiXu added a comment. In D129068#3629135 <https://reviews.llvm.org/D129068#3629135>, @vsapsai wrote:
> I don't know enough to say if it is a good approach or not, I'll need to > check what we can achieve by modifying `Profile` in > `ArgLoc.getArgument().Profile`. I tried but I don't find good solution. If you could find something workable, it should be great. > Specifically, I'm interested to see if we can use the same `ASTContext` for > profile. I tried this but it doesn't work. They refer to the same `ASTContext`. > Also I have a few stylistic comments but I want to figure out high-level > stuff first. Of course. > And I have some ideas about the tests. It might be covered elsewhere but I'm > curious if there are any not-isSameTemplateParameter test cases? I am not sure what you mean about "not-isSameTemplateParameter test case". > Also it can be useless but will it work with the deeper template nesting? > Something like `C<Level1<Level2>>`. Yeah, added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129068/new/ https://reviews.llvm.org/D129068 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
