martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Thanks for the update! LGTM (with very minor naming nits).
================
Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:146
+
+static bool HandleAST(StringRef astPath) {
+
----------------
================
Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:160
+
+ FileManager fm(CI->getFileSystemOpts());
+ SmallString<128> absPath(astPath);
----------------
================
Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:171-172
+
+static int HandleFiles(ArrayRef<std::string> sourceFiles,
+ CompilationDatabase &compilations) {
+ std::vector<std::string> SourcesToBeParsed;
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128704/new/
https://reviews.llvm.org/D128704
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
