phosek added inline comments.

================
Comment at: llvm/include/llvm/Support/Compression.h:49-51
+namespace profile = llvm::compression::zlib;
+
+namespace serialize = llvm::compression::zlib;
----------------
I think we will need to support dynamically selecting (de)compression algorithm 
for both profile and serialization. For example, we should be able to use read 
profiles generated by an older version of LLVM that only supported zlib, even 
if the new one also supports zstd. Given that, I'd omit these and instead use 
`compression::zlib` everywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128953/new/

https://reviews.llvm.org/D128953

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to