hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/Grammar.h:89
// FIXME: these should be provided as extensions instead.
-enum class RecoveryStrategy : uint8_t { None, Braces };
+enum class RecoveryStrategy : uint8_t { None, Braces, Eof };
----------------
I think there should be some documentation for the strategies here. (do you
plan to add them when the above FIXME is fixed?)
================
Comment at: clang-tools-extra/pseudo/lib/grammar/GrammarBNF.cpp:122
+ // This ensures the overall parse never fails.
+ if (T->Nonterminals[Rule.Target].Name == "_") {
+ Rule.Recovery = RecoveryStrategy::Eof;
----------------
nit: use the `StartSymbol` global variable (we might want to rename it to
`Underscore`).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128795/new/
https://reviews.llvm.org/D128795
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
