ckissane marked an inline comment as done. ckissane added inline comments.
================ Comment at: clang-tools-extra/clangd/index/Serialization.cpp:242 + return error( + "Compressed string table, but compression::serialize is unavailable"); ---------------- leonardchan wrote: > nit: Could we add some function that returns a string of whatever compression > is used? This way we have a more descriptive error message showing what > specifically is unavailable. Same comment elsewhere there's logging/error > reporting but the string is "compression::serialize". sure, I can add a AlgorithmName property to the zlib namespace and future compression namespaces, then we can print out compression::serialize::AlgorithmName to see what is being used CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
