erichkeane added a comment.
I'm generally OK with this. BUT Aaron/JF/Tom should review it.
================
Comment at: clang/lib/Basic/Diagnostic.cpp:817
+ if (isPrintable(*Begin) || isWhitespace(*Begin)) {
+ OutStr.push_back(*Begin);
+ ++Begin;
----------------
OutStream << *Begin;
================
Comment at: clang/lib/Basic/Diagnostic.cpp:837
+ llvm::sys::unicode::isFormatting(CodepointValue)) {
+ OutStr.append(CodepointBegin, CodepointEnd);
+ continue;
----------------
Something here that uses the stream?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108469/new/
https://reviews.llvm.org/D108469
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
