vext01 added inline comments.
================ Comment at: llvm/docs/DeveloperPolicy.rst:112-114 -When submitting patches, please do not add confidentiality or non-disclosure -notices to the patches themselves. These notices conflict with the LLVM -licensing terms and may result in your contribution being excluded. ---------------- aaron.ballman wrote: > I don't think we want to lose this bit either, as I don't think this advice > has changed. Oops, you are right. My bad! ================ Comment at: llvm/docs/DeveloperPolicy.rst:419-421 -Your first commit to a repository may require the autogenerated email to be -approved by a moderator of the mailing list. -This is normal and will be done when the mailing list owner has time. ---------------- aaron.ballman wrote: > Rather than get rid of this, I think we might actually want to broaden it. I > read this blurb as letting folks know that sometimes commit messages take a > while before they show up on the commit list. It used to be the primary way > that happened was when making a commit for the first time. Now it happens > most often for large commits (due to the size of the email content) or a long > list of CCs (often added automatically by Herald, though the moderation of > these has gotten better in recent history). > > I think it's kind of helpful to let people know that sometimes the automated > emails get caught out by moderation. But if others don't think that's of > value to mention, then we can go ahead and remove this bit. Actually, now I read it again, I realise that I don't understand what this sentence means: > Your first commit to a repository may require the autogenerated email to be > approved by a moderator of the mailing list. My first commit to a llvm repository was via github, and github doesn't discriminate. If you have write-access to the repo, then your push to `main` will surely go ahead. There are no automated emails involved as far as I know. I suspect this prose is from pre-github, where the process was different? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128645/new/ https://reviews.llvm.org/D128645 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
