sagarkulkarni19 marked 2 inline comments as done.
sagarkulkarni19 added inline comments.
================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:342
+ if (HasSME)
+ Builder.defineMacro("__ARM_FEATURE_SME", "1");
+
----------------
sdesmalen wrote:
> sagarkulkarni19 wrote:
> > sdesmalen wrote:
> > > When this macro is non-zero, it suggests that the compiler implements the
> > > full SME ACLE. That is currently not yet the case, so until then we
> > > should leave this macro undefined.
> > Okay makes sense. But until all SME ACLE is implemented, do we need some
> > sort of guard in the meantime while the SME intrinsics that are implemented
> > incrementally?
> The tests need to have manual `-D__ARM_FEATURE_SME` in the RUN lines. Once
> the feature is implemented and we add the definition automatically when +sme
> is specified, we update the tests. See for example D81725 where we did this
> for SVE.
Thanks. That makes sense, now the macro is undefined and I have updated the
testcases accordingly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127910/new/
https://reviews.llvm.org/D127910
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
