hctim added a comment.

In D127544#3609343 <https://reviews.llvm.org/D127544#3609343>, 
@hubert.reinterpretcast wrote:

> In D127544#3609335 <https://reviews.llvm.org/D127544#3609335>, @hctim wrote:
>
>> Sent fadc98b06befb674fa47da4f3d8606bf61bed681 
>> <https://reviews.llvm.org/rGfadc98b06befb674fa47da4f3d8606bf61bed681> to 
>> fix-forward.
>
> I thought `*-registered-target` is true as long as the target is available, 
> not only when the target happens to be the default.
> Also, if there would be more such tests in the future, maybe a LIT feature 
> that the default target supports HWAsan makes sense?

Too right. Given the purpose of this test is to just check that the globals 
have the right IR attributes, any target is fine - as the IR attributes aren't 
target-specific.

Took another fix-forward whack-a-mole attempt, committing in a sec.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127544/new/

https://reviews.llvm.org/D127544

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to