MaskRay added inline comments.
================
Comment at: clang/test/Driver/coverage-ld.c:43
+// RUN: | FileCheck --check-prefix=CHECK-OPENBSD-X86-64 %s
+//
+// CHECK-OPENBSD-X86-64: "{{(.*[^-.0-9A-Z_a-z])?}}ld{{(.exe)?}}"
----------------
Don't add `//\n` by cargo cult. It's not a recommended style (Having blank
lines helps `{` `}` in Vim like editors)
================
Comment at: clang/test/Driver/coverage-ld.c:45
+// CHECK-OPENBSD-X86-64: "{{(.*[^-.0-9A-Z_a-z])?}}ld{{(.exe)?}}"
+// CHECK-OPENBSD-X86-64:
"{{.*}}/Inputs/resource_dir{{/|\\\\}}lib{{/|\\\\}}openbsd{{/|\\\\}}libclang_rt.profile-x86_64.a"
+//
----------------
Note: the new recommended libclang_rt* hierarchy is
`LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on`. This matches
LLVM_ENABLE_RUNTIMES='compiler-rt;libcxx;libcxxabi;libunwind'.
OpenBSD hasn't switched, though.
With the new hierarchy, the location may look like:
`lib/x86_64-unknown-openbsd/libclang_rt.profile.a`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128512/new/
https://reviews.llvm.org/D128512
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
