LegalizeAdulthood added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:190 + + containsFunc |= (CanDecl == Func); + overlap |= Callees.contains(CanDecl); ---------------- Personally I'm not a fan of using bitwise operators with booleans. It involves implicit casts of bool to int and int to bool and doesn't use the usual short-circuiting logic of `||` and `&&`. It also means this code won't be analyzed by clang-tidy as "performing operations on booleans" for things like `readability-simplify-boolean-expr`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
