tlively added a comment.

In D128282#3601100 <https://reviews.llvm.org/D128282#3601100>, @asb wrote:

> In D128282#3600355 <https://reviews.llvm.org/D128282#3600355>, @tlively wrote:
>
>> I think the lines still differ in that one tests wasm32 and the other tests 
>> wasm64 (the triples are different).
>
> Yeah, but the convention used elsewhere in this test file is to use 
> `WEBASSEMBLY:` (which is a common check prefix for both wasm32 and wasm64 run 
> lines) in the cases where the output is the same.

Ohh, for some reason I thought you were talking about the RUN lines. Yes, 
combining the check lines would make sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128282/new/

https://reviews.llvm.org/D128282

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to