vangthao added a comment.

In D127923#3599451 <https://reviews.llvm.org/D127923#3599451>, @aaron.ballman 
wrote:

> Is there a reason the remarks can't use individual diagnostic emissions to 
> simulate newlines? Or is this perhaps a demonstration that the remarks should 
> not be using the diagnostic engine at all and should be emitting their output 
> to a user-controllable stream (or file)?

An issue with using multiple diagnostic emissions to simulate newlines is that 
there are repeated information such as diagnostic location and diagopts 
reprinted for each line. This creates a lot of noise and makes the output 
harder to read. Accepting newlines in diagnostics would allow for a lot more 
flexibility but I do see your point on how it would also encourage longer 
diagnostics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127923/new/

https://reviews.llvm.org/D127923

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to