reames added a comment. Ok, with the revised description, let me start anew in my response.
I don't have any particular problem with this change. I do think it would be good to explicitly update the docs to indicate whether the param can be null or not, but given a) gcc has allowed it, and b) the performance impact should be minimal, I would see no concerns with just documenting the current gcc state and implementing it in clang. That seems like the path of least resistance here and is a reasonable outcome. I'm not worried about perf impact from the null check as idiomatic usage is likely to involve taking the address of a local variable which will be trivially non-null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm.org/D126461 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
