reames added a comment. In D126461#3597862 <https://reviews.llvm.org/D126461#3597862>, @craig.topper wrote:
> `dst` in the patch description is not the pointer being loaded, it's the > pointer of where to store the new_vl. That is only thing being checked for > null in this patch. I agree this is a possible interpretation, but it's also inconsistent with some of the other review discussion above. @pcwang-thead Please consider clarifying the patch description a blocking item for future review or potential approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm.org/D126461 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits