MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.

Thanks for the Screenshot, please remember to mark your comments as "Done" once 
you've addressed them. From what I can tell this looks good.



================
Comment at: clang/include/clang/Format/Format.h:3559
           AfterFunctionDefinitionName(false), AfterIfMacros(false),
-          AfterOverloadedOperator(false), AfterRequiresInClause(false),
-          AfterRequiresInExpression(false), BeforeNonEmptyParentheses(false) {}
+          AfterOverloadedOperator(false), AfterPlacementOperator(APO_Always),
+          AfterRequiresInClause(false), AfterRequiresInExpression(false),
----------------
HazardyKnusperkeks wrote:
> As said in the other comment, there is code that depends on setting to never 
> in the default constructor, so please do.
Why Never and not Leave? basically introducing one or the other as a default 
won't that causes changes for people who don't want to use this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127270/new/

https://reviews.llvm.org/D127270

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to